Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Assert transform #249

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Add Assert transform #249

merged 4 commits into from
Dec 1, 2023

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Dec 1, 2023 •
edited
Loading

closes #247

@eliascarv eliascarv requested a review from juliohm December 1, 2023 18:29
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa1ac27) 94.52% compared to head (5bbf678) 94.57%.

❗ Current head 5bbf678 differs from pull request most recent head 793c2bf. Consider uploading reports for the commit 793c2bf to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   94.52%   94.57%   +0.04%     
==========================================
  Files          44       44              
  Lines        1316     1328      +12     
==========================================
+ Hits         1244     1256      +12     
  Misses         72       72

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliascarv eliascarv changed the title Make SciTypeAssertion a transform Add Assert trasnform Dec 1, 2023
@eliascarv eliascarv changed the title Add Assert trasnform Add Assert transform Dec 1, 2023
@eliascarv eliascarv merged commit 74200f0 into master Dec 1, 2023
7 checks passed
@eliascarv eliascarv deleted the assertions branch December 1, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliohm juliohm juliohm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor assertion infrastructure
3 participants
@eliascarv @codecov-commenter @juliohm