Fix indexing (#37)

* Fix indexing bug * Restore testing
JuliaLinearAlgebra · Jul 15, 2018 · b3d97fc · b3d97fc
1 parent 2610b68
commit b3d97fc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/ToeplitzMatrices.jl b/src/ToeplitzMatrices.jl
@@ -31,7 +31,9 @@ include("iterativeLinearSolvers.jl")
 abstract type AbstractToeplitz{T<:Number} <: AbstractMatrix{T} end
 
 size(A::AbstractToeplitz) = (size(A, 1), size(A, 2))
-getindex(A::AbstractToeplitz, i::Integer) = A[mod(i, size(A,1)), div(i, size(A,1)) + 1]
+function getindex(A::AbstractToeplitz, i::Integer)
+    return A[mod(i - 1, size(A, 1)) + 1, div(i - 1, size(A, 1)) + 1]
+end
 
 convert(::Type{AbstractMatrix{T}}, S::AbstractToeplitz) where {T} = convert(AbstractToeplitz{T}, S)
 convert(::Type{AbstractArray{T}}, S::AbstractToeplitz) where {T} = convert(AbstractToeplitz{T}, S)

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -39,6 +39,8 @@ xl = randn(nl, 5)
 
         @test As * xs ≈ Matrix(As) * xs
         @test Al * xl ≈ Matrix(Al) * xl
+        @test [As[n] for n in 1:length(As)] == vec(As)
+        @test [Al[n] for n in 1:length(Al)] == vec(Al)
         @test ldiv!(As, Compat.LinearAlgebra.copy_oftype(xs, eltype(As))) ≈ Matrix(As) \ xs
         @test ldiv!(Al, Compat.LinearAlgebra.copy_oftype(xl, eltype(Al))) ≈ Matrix(Al) \ xl
     end