Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update progress bar style to match 1.12 progress bar #1066

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

christiangnrd
Copy link
Contributor

Couldn't get the smoother version without causing some issues with the colour printing.

I moved the ':' out of the prefix as it was too blue for me but I can revert that if people don't like it.

@tecosaur
Copy link
Contributor

tecosaur commented Oct 9, 2024

It would be good to use both the left and right half-bar characters.

@christiangnrd
Copy link
Contributor Author

christiangnrd commented Oct 9, 2024

It would be good to use both the left and right half-bar characters.

@tecosaur I agree, but I couldn't find how to have the right half-bar character use the alternate colour instead of the main colour.

image

If there's an easy fix suggested, I'll integrate it with this PR. Otherwise, I suggest we merge this until a more involved solution is implemented.

@christiangnrd
Copy link
Contributor Author

Didn't mean to close sorry for the spam

@tecosaur
Copy link
Contributor

tecosaur commented Oct 9, 2024

We're using a progress bar library? The only non-trivial component in implementing a progress bar ourselves is the ETA.

@christiangnrd
Copy link
Contributor Author

IMO this should be merged as-is for now as it's still an improvement, and I'll open an issue to improve it so that I can remember to return to it in an unknown amount of time if someone else hasn't gotten to it first.

@davidanthoff
Copy link
Collaborator

Hm, I have to admit I find that visually way more difficult to distinguish than the existing progress bar... Everything is super small (why is this like two pixels high, only?), the difference in color between "finished" and "in progress" (blue and black) is hard to see... All the default options shown here https://crates.io/crates/indicatif (the progress bar package we use) are way easier on the eye to me...

@tecosaur
Copy link
Contributor

Even if it's not visually great to some eyes (I suspect this is a little font-dependent too), I do think there's a fair bit of value in consistency with Pkg.

@davidanthoff
Copy link
Collaborator

Let's hold this for now, the earliest we should merge this is when 1.12 is actually released.

@christiangnrd christiangnrd force-pushed the progressbar branch 2 times, most recently from 0685554 to 38780d1 Compare October 13, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants