-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpart: Start enforcing min_world for global variable definitions #57150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
force-pushed
the
kf/globalminworld
branch
from
January 24, 2025 03:41
a06285c
to
b53c87e
Compare
Keno
added a commit
to JuliaLang/Distributed.jl
that referenced
this pull request
Jan 25, 2025
The internal function `jl_set_const` is allowed during bootstrap only and ignores world age partition. This would give incorrect results after JuliaLang/julia#57150. Just eval the constant definition directly, which has well defined semantics.
Keno
force-pushed
the
kf/globalminworld
branch
from
January 25, 2025 04:57
b53c87e
to
dfa20f4
Compare
Distributed test failure is JuliaLang/Distributed.jl#125. |
JamesWrigley
pushed a commit
to JuliaLang/Distributed.jl
that referenced
this pull request
Jan 26, 2025
The internal function `jl_set_const` is allowed during bootstrap only and ignores world age partition. This would give incorrect results after JuliaLang/julia#57150. Just eval the constant definition directly, which has well defined semantics.
JamesWrigley
pushed a commit
to JuliaLang/Distributed.jl
that referenced
this pull request
Jan 26, 2025
The internal function `jl_set_const` is allowed during bootstrap only and ignores world age partition. This would give incorrect results after JuliaLang/julia#57150. Just eval the constant definition directly, which has well defined semantics.
Needs #57169 I presume. |
@Keno Here's the test failure now:
|
Keno
force-pushed
the
kf/globalminworld
branch
from
January 28, 2025 01:24
7f6d503
to
036bc6f
Compare
This is the analog of #57102 for global variables. Unlike for consants, there is no automatic global backdate mechanism. The reasoning for this is that global variables can be declared at any time, unlike constants which can only be decalared once their value is available. As a result code patterns using `Core.eval` to declare globals are rarer and likely incorrect.
Keno
force-pushed
the
kf/globalminworld
branch
from
January 28, 2025 22:51
036bc6f
to
e7b83ba
Compare
I assume this test noise from the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the analog of #57102 for global variables. Unlike for consants, there is no automatic global backdate mechanism. The reasoning for this is that global variables can be declared at any time, unlike constants which can only be decalared once their value is available. As a result code patterns using
Core.eval
to declare globals are rarer and likely incorrect.