Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md, flisp parser, and REPL #57143

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pthariensflame
Copy link
Contributor

@pthariensflame pthariensflame commented Jan 23, 2025

Now that JuliaLang/JuliaSyntax.jl#525 has been merged, also add it to the flisp parser, and document it!

@Keno
Copy link
Member

Keno commented Jan 23, 2025

Also needs to be added in the flisp parser and needs to wait for the JuliaSyntax version bump.

@nsajko nsajko added the docs This change adds or pertains to documentation label Jan 23, 2025
@pthariensflame pthariensflame changed the title Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md and flisp parser Jan 24, 2025
@pthariensflame
Copy link
Contributor Author

@Keno @nsajko This PR now also adds support for U+1F8B2 🢲 to the flisp parser and with it the Base id char functions.

@pthariensflame pthariensflame force-pushed the patch-2 branch 2 times, most recently from 8720f42 to f4d279a Compare January 24, 2025 23:11
@nsajko nsajko added parser Language parsing and surface syntax feature Indicates new feature / enhancement requests needs tests Unit tests are required for this change and removed docs This change adds or pertains to documentation labels Jan 25, 2025
@nsajko
Copy link
Contributor

nsajko commented Jan 25, 2025

I'm guessing this PR will also need tests, so I added the label.

Correspondingly adds it to the Base id char functions too
@pthariensflame
Copy link
Contributor Author

@nsajko I'm not sure what to test; I can't find any tests for the other arrow operators that already exist.

@pthariensflame pthariensflame changed the title Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md and flisp parser Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md, flisp parser, and REPL Feb 1, 2025
@nsajko
Copy link
Contributor

nsajko commented Feb 1, 2025

I'd write a simple test like this one:

@testset "RIGHTWARDS ARROW WITH LOWER HOOK" begin
    🢲(l, r) = 2l + 3r
    @test 5 === (1 🢲 1)
end

Perhaps also something to test its operator precedence?

Something like this could be fine, too:

julia/test/syntax.jl

Lines 2274 to 2280 in 9a278a2

# issue 45962
@testset "binary ⭄, ⥺, ⭃, and ⥷" begin
@test Meta.parse("a ⭄ b") == Expr(:call, :, :a, :b)
@test Meta.parse("a ⥺ b") == Expr(:call, :, :a, :b)
@test Meta.parse("a ⭃ b") == Expr(:call, :, :a, :b)
@test Meta.parse("a ⥷ b") == Expr(:call, :, :a, :b)
end

@pthariensflame
Copy link
Contributor Author

@nsajko Added something based on your second example and the others in that file.

@nsajko nsajko removed the needs tests Unit tests are required for this change label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates new feature / enhancement requests parser Language parsing and surface syntax
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants