Backport #50832 to v1.10

[mofeing]

fixes #55933

This backports #50832 to v1.10.

[mofeing]

CC @wsmoses

[mofeing]

Failed tests seem unrelated to this PR:

Error in testset Pkg:
Test Failed at /cache/build/tester-amdci4-10/julialang/julia-release-1-dot-10/julia-bd32e389dd/share/julia/stdlib/v1.10/Pkg/test/new.jl:803
  Expression: ((Pkg.dependencies())[exuuid]).version == v"0.5.3"
   Evaluated: v"0.5.5" == v"0.5.3"
Error in testset Pkg:
Test Failed at /cache/build/tester-amdci4-10/julialang/julia-release-1-dot-10/julia-bd32e389dd/share/julia/stdlib/v1.10/Pkg/test/pkg.jl:279
  Expression: ((Pkg.dependencies())[TEST_PKG.uuid]).version > old_v
   Evaluated: v"0.5.5" > v"0.5.5"
Error in testset Pkg:
Test Failed at /cache/build/tester-amdci4-10/julialang/julia-release-1-dot-10/julia-bd32e389dd/share/julia/stdlib/v1.10/Pkg/test/repl.jl:86
  Expression: ((Pkg.dependencies())[TEST_PKG.uuid]).version > v
   Evaluated: v"0.5.5" > v"0.5.5"

[giordano]

That's because you're branch is old and doesn't have the backport of Pkg.jl which fixed that.

[DilumAluthge]

@mofeing I think that this should target the backports-release-1.10 branch.

[DilumAluthge]

Agh I changed the target branch, but Git did not like that.

[wsmoses]

Can you just reset the branch to back ports and cherry pick the commit

[giordano]

@mofeing I think that this should target the backports-release-1.10 branch.

That doesn't exist anymore.

Agh I changed the target branch, but Git did not like that.

Probably because it's the wrong branch.

[giordano]

Isn't it easier to label #50832 as backport to 1.10 and wait for the next v1.10 release to handle all of this automatically?

[mofeing]

That's because you're branch is old and doesn't have the backport of Pkg.jl which fixed that.

@giordano mmm I just updated my release-1.10 branch and cherry-picked the commit again, but same error. GitHub just trolled me.

Isn't it easier to label #50832 as backport to 1.10 and wait for the next v1.10 release to handle all of this automatically?

Does it mean that I shouldn't do anything else and just close this PR?

[giordano]

Does it mean that I shouldn't do anything else and just close this PR?

Yes

[giordano]

For the benefit of future readers, #50832 was automatically added to the list of backports for v1.10.7 in #56381