add recompile comment in --trace-compile in terminal color mode too #56275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
added
the
backport 1.11
|
I think we should just add "# recompile" always. I was confused about what the coloring meant when I first saw it anyway. Adding another symbol just makes it more confusing IMO |
|
Okay. Yeah |
… color prompt" This reverts commit f146eff.
IanButterworth
changed the title
topolarity
reviewed
Oct 21, 2024
IanButterworth
added
the
merge me
oscardssmith
added
REPL
IanButterworth
removed
the
backport 1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: Just adds the comment in color terminal mode too
I didn't think adding the
# recompiletext to the end in the repl was a good idea as it increases likelihood of text wrapping.And the color should be sufficient for local review, but when people copy from a color terminal we lose the recompile info.
So this just adds a zero-length change indicator, for people to look out for.