-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring to be considered before adding MMTk #55608
Conversation
@udesou, a comment before the review: I think rebase might be preferable over merging master to sync a branch, since it avoids interleaving your commits with the upstream ones, and keeps the log "cleaner" (e.g. all of your commits after HEAD). |
b2290d3
to
6625900
Compare
Sounds good. I was just clicking the button on GitHub without changing anything but I think I did it right this time. |
6625900
to
058d676
Compare
331ffea
to
dc25405
Compare
@udesou if you don't mind, could you perhaps click "Resolve conversation" for comments that you already addressed? That would make it a tad easier to follow what's going on here. Thank you, and thank you for this work! |
b4c573a
to
8c90a5b
Compare
51f620e
to
c23f0db
Compare
c23f0db
to
bb634b3
Compare
5805609
to
173b0db
Compare
127cc78
to
bc9e77e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the gcext failure on CI before merging.
@fingolfin: I thought we moved gcext out of "Allow Fail" and into a regular test that needs to pass for CI to be green? If not, perhaps we should consider doing it given that we'll be working on a bunch of GC PR's in the next weeks and it might be useful to have a very explicit indication (e.g. red CI) of whether we broke gcext. |
7c7c5c1
to
fe61c22
Compare
@d-netto I think it should be fixed now, however, some unrelated things seem to be failing (by looking at CI results from the latest commit in the Julia repo). If it's really unrelated, then we should be good to go, I guess. |
fe61c22
to
cd4f5a1
Compare
cd4f5a1
to
71c439c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading through it LGTM, but, as usual, let's wait for CI to merge...
29cce04
to
3662c12
Compare
@udesou. CI looks fine. Could you fix the merge conflict in |
3662c12
to
becb324
Compare
…art of the refactoring
becb324
to
e43bfa3
Compare
This PR contains some refactoring of common functions that were moved to `gc-common.c` and should be shared between MMTk and Julia's stock GC.
This PR contains some refactoring of common functions that were moved to
gc-common.c
and should be shared between MMTk and Julia's stock GC.