Fix decoration for atan
with two arguments
#672
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the decoration returned by
atan(y, x)
wheneverinf(y) >= 0
andy
contains0
andsup(x) <= 0
.N.B.:
atan
is a discontinuous function at the half-liney = 0
,x < 0
, which is included in its domain.Before this PR
which I believe is wrong since both input intervals and output intervals are bounded.
So, with this PR
Moreover, there is a test in the ITF1788 which actually depends on this choice of decoration:
which I think is wrong (for me the decoration should be
com
and notdac
). I changed this test to