Base utilities for exact reals #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think it would be good to have tests checking the compatibility with Symbolics ? (I think you are probably the main user of Symbolics + IA, so I would say it's up to you) |
|
Yes I think that would be great. I'm just not sure how to do that (a test-only dependency). |
|
There is a Project.toml file in the test folder. You could |
|
Btw you should rebase this branch If it's too complicated to add unit testing for Symbolics.jl, then I am not opposed to merge this PR as is (since it's a very straightforward feature to add). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines
Base.hashandBase.isfiniteforExactReals.This is necessary so that they work with Symbolics.jl.