Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up hull #663

Closed
wants to merge 1 commit into from
Closed

Speed up hull #663

wants to merge 1 commit into from

Conversation

dpsanders
Copy link
Member

No description provided.

@OlivierHnt
Copy link
Member

OlivierHnt commented May 31, 2024

In #664 I added a feature of this PR: the resulting decoration does not depend on decoration(r).

In the current status of this PR, I think this is the only small improvement we can get.
For instance, removing isempty_interval(x) & isempty_interval(y) && return x breaks a few things since:

  • internally the bounds of an empty interval are NaN (unless we are using intervals with rational bounds); this was done for extra safety IIRC since NaN propagates
  • but publicly, inf and sup on an empty interval return Inf and -Inf respectively; to comply with the standard

Unless you are still trying things out, I suggest to close this PR.

@dpsanders
Copy link
Member Author

What does removing isempty_interval(x) & isempty_interval(y) && return x break?

@dpsanders
Copy link
Member Author

Oh, I see what you're saying :/ That... is unfortunate. Closing for now, thanks.

@dpsanders dpsanders closed this May 31, 2024
@OlivierHnt OlivierHnt deleted the dps-speedup-hull branch June 8, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants