Update FFMPEG to use 6.1.1 #59
Conversation
|
It looks like OpenSSL has a compatibility issue in 1.3. The version needed by FFMPEG_jll does not exist for 1.3 |
|
|
||
| [deps] | ||
| FFMPEG_jll = "b22a6f82-2f65-5046-a5b2-351ab43fb4e5" | ||
|
|
||
| [compat] | ||
| FFMPEG_jll = "4.3.1" | ||
| FFMPEG_jll = "4.3.1, 6.1.1" |
There was a problem hiding this comment.
Hmmm.. I'm not sure about adding this in a patch release.
At least can we check VideoIO.jl tests before releasing this
There was a problem hiding this comment.
Hmmm.. I'm not sure about adding this in a patch release.
I agree, that would also mean moving the julia bound to 1.6
At least can we check VideoIO.jl tests before releasing this
By this do you mean testing locally?
There was a problem hiding this comment.
Maybe also move to v1.0.0 altogether, to avoid the mess of using only two version numbers, this package hasn't been touched in 3 years, looks moderately stable.
There was a problem hiding this comment.
By this do you mean testing locally?
You could edit the VideoIO CI to dev this branch and test on a PR
There was a problem hiding this comment.
Maybe also move to v1.0.0 altogether, to avoid the mess of using only two version numbers, this package hasn't been touched in 3 years, looks moderately stable.
I see there are these drone CI running on Julia 1.3 - 1.5, can I remove it safely?
There was a problem hiding this comment.
The Drone service is completely broken, just remove it.
There was a problem hiding this comment.
I also remove AppVeyor as the service in Julia is unmaintained and version still refers to 1.5
|
except for appveyor build failing, all tests pass. is there a reason not to merge? |
|
I think the issues in JuliaIO/VideoIO.jl#418 are resolved. It seems newer FFMPEG just returns greater precision for duration queries. |
Project.toml
Outdated
| version = "0.4.1" | ||
| version = "1.0.0" |
There was a problem hiding this comment.
I don't think this needs to be a breaking change.
There was a problem hiding this comment.
Or is it so because of the minimum julia version bump?
There was a problem hiding this comment.
That's not a breaking change, it only warrants a change in the second non-zero number.
| @@ -1,14 +1,14 @@ | |||
| name = "FFMPEG" | |||
| uuid = "c87230d0-a227-11e9-1b43-d7ebe4e7570a" | |||
| authors = ["SimonDanisch <[email protected]>"] | |||
| version = "0.4.2" | |||
| version = "1.0.0" | |||
There was a problem hiding this comment.
Ref. #59 (comment)
| version = "1.0.0" | |
| version = "0.4.3" |
Updated compat and removed avresample reference: https://bugs.gentoo.org/722274