Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Aqua workflow to test things further #436

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Use the Aqua workflow to test things further #436

wants to merge 10 commits into from

Conversation

theogf
Copy link
Member

@theogf theogf commented Feb 14, 2022

This adds tests for the Aqua.jl workflow. It tests methods ambiguities, exported non-existing functions, lost parameters and more.

src/distances/sinus.jl Outdated Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.88%. Comparing base (2a6e5e9) to head (e8c9702).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          52       52           
  Lines        1459     1459           
=======================================
  Hits         1326     1326           
  Misses        133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theogf theogf closed this Apr 20, 2022
@yebai yebai deleted the tgf/aqua branch January 13, 2023 20:11
@simsurace simsurace restored the tgf/aqua branch March 9, 2024 23:23
@simsurace simsurace reopened this Mar 9, 2024
test/Project.toml Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@theogf
Copy link
Member Author

theogf commented Mar 11, 2024

Well the type piracy is explicit in a comment:

# Note that this is type piracy as the derivative should be NaN for x == y.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants