-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for ndims query #551
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
@maleadt the idea would be that backends could write in their index functions:
But this fails if workgroups are bigger than what the launch configuration supports. |
|
ab0e6fd
to
cc9bf88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runic suggested the following formatting changes.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@@ -30,3 +30,4 @@ end | |||
|
|||
@inline groupsize(ctx) = __groupsize(ctx) | |||
@inline ndrange(ctx) = __ndrange(ctx) | |||
@inline Base.ndims(ctx) = ndims(__iterspace(ctx)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arrrrrrrr! Attack of the pirates!!! This is causing a lot of downstream breakage: can it not dispatch on ctx being a context object?
No description provided.