-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from AbstractDifferentiation to DifferentiationInterface #93
Switch from AbstractDifferentiation to DifferentiationInterface #93
Conversation
Any idea why the benchmarks fail? Or opinions on the preparation mechanism, which I could add to the present PR? |
@gdalle thanks for this! I need to take a deeper look into why the benchmarks fail, seems like something ends up in an endless loop, so maybe it's something to fix upstream. Regarding preparation: maybe it can be added separately, with some mechanism to make it optional |
Fixed the conflicts, this should be good to go! We can always discuss preparation in a separate PR |
@lostella can you authorize the workflows? |
It seems the benchmarks worked for the PR branch but failed for the main branch? |
Yes I think this is expected, since the change is breaking and the benchmark code won't work with the previous commit, right? I don't know of a better method to organize benchmarks for these cases. I think it's fine, nothing to worry about. I'll just take a manual look at performance before merging, otherwise this looks good, thank you! |
Co-authored-by: Lorenzo Stella <[email protected]>
Hi @lostella, just popping by to see if you need anything else from me |
While we're at it, do you want to try to update to DI v0.6, which just landed? |
Makes sense! |
Following our discussion per email, this PR proposes a switch from AbstractDifferentiation.jl to DifferentiationInterface.jl, which is becoming the new standard in the ecosystem.
Project.toml
files and importsSomethingBackend()
withAutoSomething()
value_and_gradient_closure
withvalue_and_gradient
(unclear how performance is affected)