Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct interpretation for compile with AutoReverseDiff #613

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Nov 6, 2024

Versions

  • Bump DI to v0.6.21

DI extensions

ReverseDiff:

  • Use the correct interpretation for compile in AutoReverseDiff: it specifies that tape recording is safe during preparation. If compile=false, the tape is now re-recorded every time by DI.

Related:

@gdalle gdalle marked this pull request as ready for review November 6, 2024 14:46
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (40ef1a7) to head (5ecb03b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
+ Coverage   97.51%   97.77%   +0.25%     
==========================================
  Files         110      110              
  Lines        5384     5427      +43     
==========================================
+ Hits         5250     5306      +56     
+ Misses        134      121      -13     
Flag Coverage Δ
DI 98.93% <100.00%> (+0.38%) ⬆️
DIT 95.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 0da5429 into main Nov 6, 2024
46 checks passed
@gdalle gdalle deleted the gd/reversediff branch November 6, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant