Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AbstractVectors #45

Merged
merged 2 commits into from
May 23, 2023
Merged

Conversation

baggepinnen
Copy link
Contributor

Otherwise I run into problems with the ComponentVector suggestion in the docs

@gdalle
Copy link
Member

gdalle commented May 23, 2023

Thanks a bunch! There was a major refactor for v0.4 and I didn't check everything, I'll add an example with ComponentVectors

@gdalle gdalle linked an issue May 23, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.63 🎉

Comparison is base (c854b5d) 90.78% compared to head (7bf92b5) 93.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   90.78%   93.42%   +2.63%     
==========================================
  Files           5        5              
  Lines          76       76              
==========================================
+ Hits           69       71       +2     
+ Misses          7        5       -2     
Impacted Files Coverage Δ
src/utils.jl 76.47% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gdalle gdalle merged commit a710a81 into JuliaDecisionFocusedLearning:main May 23, 2023
@baggepinnen baggepinnen deleted the patch-1 branch May 23, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems CI on 1.6 fails because of this line
2 participants