Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Krylov solver verbose and public #157

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Make Krylov solver verbose and public #157

merged 1 commit into from
Sep 26, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 26, 2024

  • Make KrylovLinearSolver part of the public API
  • Add verbose keyword to KrylovLinearSolver which throws warning when !stats.solved || stats.inconsistent (ping @benjaminfaber who ran into related issues on Discourse)
  • Merge docstrings

Related:

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/implicit_function.jl 88.88% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/ImplicitDifferentiation.jl 100.00% <ø> (ø)
src/implicit_function.jl 90.62% <88.88%> (-2.48%) ⬇️

@gdalle gdalle merged commit a2ad001 into main Sep 26, 2024
3 of 4 checks passed
@gdalle gdalle deleted the gd/verbose_solver branch September 26, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant