Warning preparestate!, debug InternalModel, reduce alloc PredictiveController
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid possible confusion with MHE `p` constant
…c estimate removed: `evalŷ` method (useless with new `preparestate!`) added: warning if `evaloutput` is called before `preparestate!` with current estimators added: warning if `moveinput!` is called before `preparestate!`with current estimators tests: calling `preparestate!` where needed to avoid the warnings
franckgaga
changed the title
InternalModel and reduce alloc PredictiveControllerpreparestate!, debug InternalModel, reduce alloc PredictiveController
another clearer error is thrown later in the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preparestate!is called aftermoveinput!orevaloutputwith current estimatorsmoveinput!calls with newbufferobjectsevaloutputonInternalModelnow include current stochastic estimateevaloutputcorrectness onInternalModelpreparestate!where needed to avoid the warnings