Update s3_list_objects() to use ListObjectsV2 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Peter, welcome to back to Julia! There's already a merge request opened up for this #64 and the discussion around it. |
|
Oh, oops! Shame on me for failing to look at open pull requests! I'll take a look, but I suspect there is unlikely to be anything in my code that is better or even substantially different than what's there. (Allowing the possibility that their code is much better than attempt of course :-) ) |
|
No worries! :) I'm going to close this merge request, but I'm sure we can x-post this over and unify things if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I noticed that this library was still using the ListObjects API, which has been deprecated in favor of ListObjectsV2 (https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjects.html). I thought I would use this as an opportunity to dip my feet back into Julia after a few years. Style or other suggestions / corrections humbly welcomed.