Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laguerre Derivatives #113

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ioannisPApapadopoulos
Copy link
Member

@dlfivefifty Is there a reason why the LaguerreWeight axis was originally all of R rather than just the HalfLine?

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 89.93% // Head: 89.93% // No change to project coverage 👍

Coverage data is based on head (bb63d69) compared to base (bb63d69).
Patch has no changes to coverable lines.

❗ Current head bb63d69 differs from pull request most recent head a8af5be. Consider uploading reports for the commit a8af5be to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files          17       17           
  Lines        1958     1958           
=======================================
  Hits         1761     1761           
  Misses        197      197           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dlfivefifty
Copy link
Member

Sounds like a bug. Note DomainSets.jl has

julia> HalfLine()
0.0..Inf (closed–open) (HalfLine)

test/test_stieltjes.jl Outdated Show resolved Hide resolved
@ioannisPApapadopoulos
Copy link
Member Author

@dlfivefifty It's currently failing because L \ (x .* L) goes via \(L::Laguerre, K::Laguerre) which seems a bit odd..

@dlfivefifty
Copy link
Member

It's not odd because x .* L simplifies to L * jacobimatrix(L) then L \ (L * jacobimatrix(L)) simplifies to (L \L) * jacobimatrix(L). So we want L\L to work (at least the case the parameters are the same in which case it should return SquareEye{T}(∞))

@ioannisPApapadopoulos
Copy link
Member Author

Yep, just clocked that! The same thing was causing Laguerre(a+1) \ Derivative(x)*Laguerre(a) to fail. All fixed.

@dlfivefifty
Copy link
Member

This should be split into two PRs: one in SingularIntegrals.jl

@dlfivefifty dlfivefifty changed the title Implement Hilbert transform of LaguerreWeight (and thus all of Laguerre) Laguerre Derivatives Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants