Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detection of target chain for VariationalDEO #292

Merged
merged 13 commits into from
Oct 22, 2024
Merged

Fix detection of target chain for VariationalDEO #292

merged 13 commits into from
Oct 22, 2024

Conversation

miguelbiron
Copy link
Collaborator

Closes #290

alexandrebouchard
alexandrebouchard approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@alexandrebouchard alexandrebouchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miguelbiron
Copy link
Collaborator Author

Ah that failure is bc I substituted a vector (allocation) with a lazy iterator, but forgot to make the necessary changes in some places. On it now.

@miguelbiron miguelbiron merged commit ff27c73 into main Oct 22, 2024
10 checks passed
@miguelbiron miguelbiron deleted the iss290 branch October 22, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebouchard alexandrebouchard alexandrebouchard approved these changes

@nikola-sur nikola-sur Awaiting requested review from nikola-sur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sampling issue when adding variational chains
2 participants
@miguelbiron @alexandrebouchard