Fix #263

Julia-Tempering · Aug 13, 2024 · 0dc2048 · 0dc2048
1 parent 30d9565
commit 0dc2048
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/explorers/SliceSampler.jl b/src/explorers/SliceSampler.jl
@@ -134,6 +134,7 @@ end
 
 # handle integers separately
 function initialize_slice_endpoints(current::T, width, rng) where {T<:Integer}
+    @assert isinteger(width) "for integer variables, the width should be an integer. Got: $width"
     width = ceil(T, width)
     L = current - rand(rng, 0:width)
     R = L + width

diff --git a/test/test_slice_sampler.jl b/test/test_slice_sampler.jl
@@ -104,3 +104,17 @@ end
 @testset "SliceSampler" begin
     test_slice_sampler()
 end
+
+
+DynamicPPL.@model function test()
+    p ~ Categorical(0.1*ones(10))
+end
+
+
+@testset "Bad width" begin 
+    test_target = TuringLogPotential(test())
+    inputs = Inputs(target = test_target,
+                explorer = SliceSampler(w = 0.1, p = 20, n_passes = 1, max_iter = 1_024)
+                )
+    @test_throws "AssertionError: for integer variables, the width should be an integer. Got: 0.1" pt = pigeons(inputs)
+end