Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint-plugin-perfectionist to v2.10.0 #1617

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rubiesonthesky
Copy link
Collaborator

@rubiesonthesky rubiesonthesky commented May 4, 2024

PR Checklist

Overview

Supersedes #1582. This includes the lint fixes.

I'm not sure I think most of change are improvements here. It would more sense to keep existing way for some of them. So maybe it would be better to turn perfectionist/sort-intersection-types rule off for now? 🤔 I think it sort named types first and then add {} part. (Also see azat-io/eslint-plugin-perfectionist#143 and azat-io/eslint-plugin-perfectionist#128 - so there may be new config options later)

For example: NodeWithIdentifierName

It was:

export type NodeWithIdentifierName = ts.Node & {
	name: ts.Identifier;
};

And now it is:

export type NodeWithIdentifierName = {
	name: ts.Identifier;
} & ts.Node;

But that aside, this PR fixes the lint errors so we can update the eslint plugin :)

@rubiesonthesky rubiesonthesky changed the title Eslint plugin perfectionist update chore(deps): update dependency eslint-plugin-perfectionist to v2.10.0 May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant