Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple node half rotation MPI error #324

Merged
merged 4 commits into from
Nov 5, 2024
Merged

fix multiple node half rotation MPI error #324

merged 4 commits into from
Nov 5, 2024

Conversation

jiangtong1000
Copy link
Collaborator

@jiangtong1000 jiangtong1000 commented Oct 24, 2024

Fix the MPI error when running with multiple nodes and performing half_rotate, which involves the following code. scomm needs to be passed into this code.

win = MPI.Win.Allocate_shared(nbytes, itemsize, comm=comm)

Otherwise leads to

win = MPI.Win.Allocate_shared(nbytes, itemsize, comm=comm)
File "mpi4py/MPI/Win.pyx", line 116, in mpi4py.MPI.Win.Allocate_shared
mpi4py.MPI.Exception: MPI_ERR_RMA_SHARED: Memory cannot be shared

@Jinghong-Zhang also met this before.

@jiangtong1000
Copy link
Collaborator Author

pylint reported error on unmodified files. I guess github CI updated its pylint.

Copy link
Collaborator

@linusjoonho linusjoonho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiangtong1000 jiangtong1000 merged commit ed75292 into develop Nov 5, 2024
7 checks passed
@jiangtong1000 jiangtong1000 deleted the fix_mpi branch November 5, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants