Remove dot_real_cmplx function from wicks kernels. #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function assumed the cholesky intermediate was real in an attempt to save some multiplications. This assumption is incorrect in general. This fortunately did not lead to incorrect results as the formula held for both real and complex input A, which explains why the unit tests passed. Removes this in favour of * for element wise multiplication. Also force more complex walkers in the tests to exercise the code path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function assumed the cholesky intermediate was real in an attempt to save some multiplications. This assumption is incorrect in general. This fortunately did not lead to incorrect results as the formula held for both real and complex input A, which explains why the unit tests passed. Removes this in favour of * for element wise multiplication. Also force more complex walkers in the tests to exercise the code path.
Fixes #275