Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keeping flight ability after respawn #307

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

arnokeesman
Copy link
Contributor

after some digging I found that flySpeed was kept, but mayFly got reset(to false)
this made me suspect PAL having an opinion in the matter
getting PAL flight status from the old player and applying it after updating the player seems to do the trick

after some digging I found that flySpeed was kept, but mayFly got reset(to false)
this made me suspect PAL having an opinion in the matter
getting PAL flight status from the old player and applying it after updating the player seems to do the trick
@John-Paul-R
Copy link
Owner

I think that this makes sense on its own, though I'm surprised PAL doesn't handle it. I might just have an incorrect assumption of what PAL tries to do. Something to investigate for another time perhaps. I think the change is good.

@John-Paul-R John-Paul-R merged commit 30e6bc0 into John-Paul-R:1.21.x Oct 30, 2024
1 check passed
@arnokeesman
Copy link
Contributor Author

appears they do (or try)
will see what my debugger thinks about what happens tonight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants