Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix many GitHub Security Advisory Warnings #26

Merged
merged 8 commits into from
Jan 31, 2020
Merged

Fix many GitHub Security Advisory Warnings #26

merged 8 commits into from
Jan 31, 2020

Conversation

karlhorky
Copy link
Contributor

Many transitive dependency packages are locked to versions with GitHub security advisories (you probably see them under the security tab of this repo).

This pull request (original work courtesy of @juliakaltenegger) fixes many of them.

The last unresolved issue is a problem with heml (more specifically, the @heml/elements package). @juliakaltenegger alerted the heml project of this here:

SparkPost/heml#92

@Jinksi Jinksi merged commit d6cda87 into Jinksi:master Jan 31, 2020
@Jinksi
Copy link
Owner

Jinksi commented Jan 31, 2020

Thanks @karlhorky 🙌

@karlhorky
Copy link
Contributor Author

No problem, credit to @juliakaltenegger too! Thanks for the merge!

@karlhorky
Copy link
Contributor Author

@Jinksi looks like in the meantime there are more security alerts:

Yarn

$ yarn audit

...

10 vulnerabilities found - Packages audited: 914383
Severity: 1 Low | 7 Moderate | 1 High | 1 Critical

npm

$ npm i --package-lock-only && npm audit

...

found 3 vulnerabilities (1 low, 1 moderate, 1 critical) in 924332 scanned packages

@karlhorky
Copy link
Contributor Author

karlhorky commented Jan 31, 2020

The critical vulnerability comes from the heml dependency, which depends on vulnerable versions of open (also via the reload package).

Edit: I did a pull request for heml here: SparkPost/heml#98

@karlhorky
Copy link
Contributor Author

@Jinksi ok I've opened #28 to fix the rest of the vulnerabilities (except for the issues in heml, which will be resolved in SparkPost/heml#98)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants