on fetch submission data display error if there (#608)

Co-authored-by: Julien Nahum <[email protected]>
JhumanJ · Nov 13, 2024 · 2c8f7d5 · 2c8f7d5
1 parent ef12c82
commit 2c8f7d5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/api/app/Http/Controllers/Forms/PublicFormController.php b/api/app/Http/Controllers/Forms/PublicFormController.php
@@ -141,7 +141,14 @@ public function fetchSubmission(Request $request, string $slug, string $submissi
             ]);
         }
 
-        $submission = new FormSubmissionResource(FormSubmission::findOrFail($submissionId));
+        $submission = FormSubmission::find($submissionId);
+        if (!$submission) {
+            return $this->error([
+                'message' => 'Submission not found.',
+            ]);
+        }
+
+        $submission = new FormSubmissionResource($submission);
         $submission->publiclyAccessed();
 
         if ($submission->form_id != $form->id) {

diff --git a/client/components/open/forms/OpenForm.vue b/client/components/open/forms/OpenForm.vue
@@ -418,6 +418,9 @@ export default {
       await this.recordsStore.loadRecord(
         opnFetch('/forms/' + this.form.slug + '/submissions/' + this.form.submission_id).then((data) => {
           return {submission_id: this.form.submission_id, id: this.form.submission_id, ...data.data}
+        }).catch((error) => {
+          useAlert().error(error?.data?.message || 'Something went wrong')
+          return null
         })
       )
       return this.recordsStore.getByKey(this.form.submission_id)