Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #260
Problem:
teamcity-messages plugin fails in cases when the
sys.stdout
encoding is unable to handle passed symbols.This mostly happens on Windows hosts due to the behavior, described in the documentation:
How to reproduce:
Let's say we have a
test.py
file with the following content:If we run it on Windows
python3 -m pytest test.py --teamcity > test_log
then most probably encoding of the
sys.stdout
will becp1252
or something like that.And
test_log
will contain the following error:What does this pull request do:
Let's look how bad test output is handled by the pytest itself.
Let's add
assert False
line to the test and look at the result:python3 -m pytest test.py > test_log
Captured stdout is escaped.
This pull request is for the teamcity-plugin to similarly escape unencodable characters.