Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xUnit.net + dotCover 💕 : Adapted to work with teamcity 2017.2 and xunit 2.3 #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valeriob
Copy link

Copy link
Member

@pavelsher pavelsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some concerns about /net452/ part of the path. Is it possible it will change in the future?

@valeriob
Copy link
Author

valeriob commented Jan 9, 2018

it will probably change in a few years, how does this runner handle versioning and support for various version of both team-city and xunit ? it's not clear what runs with what, it took me so much time to diagnose this, you need to know internals of both project...

@dtretyakov
Copy link

@valeriob, this pull request includes two changes:

  1. Updated default path for dotCover, which is compatibility fix for TeamCity 2017.2
  2. Updated path for xunit.runner.console nuget package, which is compatibility fix for xunit 2.3+

Since in the future xunit team could change this path again, e.g. to net471, it looks that in this metarunner should be introduced parameter for xunit version which should be set to the latest supported, for instance to 2.3.1. And the runner script should handle all possible xunit versions and paths to xunit*.exe files. It'll bring guarantee that it would not be suddenly broken in the future again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants