Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test full feature separately on CI #424

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Test full feature separately on CI #424

wants to merge 2 commits into from

Conversation

tyranron
Copy link
Collaborator

@tyranron tyranron commented Nov 6, 2024 •
edited
Loading

Resolves #420

Synopsis

cargo test --no-default-features --features=full fails imposing problems on other CIs.

See #420 for more context.

Solution

  • Consider testing full Cargo feature in test-features CI job to handle such regressions.
  • Update the relevant tests to run under no_std too.

Checklist

  • Documentation is updated (not required)
  • Tests are added/updated
  • CHANGELOG entry is added (not required)

@tyranron tyranron added this to the 2.0.0 milestone Nov 6, 2024
@tyranron tyranron self-assigned this Nov 6, 2024
@tyranron tyranron marked this pull request as ready for review November 6, 2024 16:33
@tyranron tyranron requested a review from JelteF November 6, 2024 16:33
@tyranron tyranron mentioned this pull request Nov 6, 2024
Open
@tyranron tyranron enabled auto-merge (squash) November 6, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelteF JelteF Awaiting requested review from JelteF

At least 1 approving review is required to merge this pull request.

Assignees

@tyranron tyranron

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

cargo test --no-default-features --features=full fails because of no_std
1 participant
@tyranron