Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nightly cfg from impl crate #394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove nightly cfg from impl crate #394

wants to merge 1 commit into from

Conversation

JelteF
Copy link
Owner

@JelteF JelteF commented Aug 6, 2024

We can use rustversion for this. For some of the tests its still
needed because of this error:

error[E0658]: non-inline modules in proc macro input are unstable
  --> tests/error/mod.rs:53:1
   |
53 | mod nightly;
   | ^^^^^^^^^^^^
   |
   = note: see issue #54727 <https://github.com/rust-lang/rust/issues/54727> for more information

@JelteF
Remove nightly cfg from impl crate
99af35c 
We can use `rustversion` for this. For some of the tests its still
needed because of this error:

```
error[E0658]: non-inline modules in proc macro input are unstable
  --> tests/error/mod.rs:53:1
   |
53 | mod nightly;
   | ^^^^^^^^^^^^
   |
   = note: see issue #54727 <rust-lang/rust#54727> for more information
```
@JelteF
Copy link
Owner Author

JelteF commented Aug 6, 2024

Hmm, okay apparently I cannot use rustversion in doc tests (which is where we need it). So I'll leave this open to look again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JelteF