Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unbuild
withtsup
for more default export ergonomics.unbuild
was fine as long as we added a patch script to exportdefault
in CJS. However that's a bit unexpected in CJS; you would expect to just doconst rxjsX = require('eslint-plugin-rxjs-x');
without.default
tacked onto the end.tsup
lets us build different output for CJS that's more ergonomic for CJS users.assert { type: 'json' }
sinceesbuild
doesn't support it combined with named exports.