Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies path and issues with secure boot key #100

Merged
merged 13 commits into from
Apr 9, 2024
Merged

Fix dependencies path and issues with secure boot key #100

merged 13 commits into from
Apr 9, 2024

Conversation

JasonN3
Copy link
Owner

@JasonN3 JasonN3 commented Apr 5, 2024

No description provided.

@JasonN3 JasonN3 added the bug Something isn't working label Apr 5, 2024
@JasonN3 JasonN3 added this to the v1.2.0 milestone Apr 5, 2024
@JasonN3 JasonN3 self-assigned this Apr 5, 2024
@JasonN3
Copy link
Owner Author

JasonN3 commented Apr 5, 2024

/run build container

@noelmiller
Copy link
Collaborator

noelmiller commented Apr 6, 2024

Looks like most everything is working on this branch except a few things:

  1. Make Targets seem to not work properly, see https://github.com/ublue-os/bluefin/actions/runs/8583351116/job/23522456937 for details. I commented out the code to test other functionality. UPDATE: Gonna open a separate issue for resolving this. This already has too many things being changed for 1 PR.
  2. Secure Boot is broken, it is not copying over sb_pubkey.der in the xorriso step, opened issue: [BUG] xorriso is not copying over sb_pubkey.der #102

@noelmiller noelmiller self-assigned this Apr 8, 2024
@noelmiller
Copy link
Collaborator

noelmiller commented Apr 8, 2024

/run tests

@noelmiller noelmiller changed the title Fix dependencies path Fix dependencies path and issues with secure boot key Apr 8, 2024
@noelmiller
Copy link
Collaborator

Fixes: #102 and issues with flatpak dependencies.

xorriso/gen_input.sh Outdated Show resolved Hide resolved
@noelmiller
Copy link
Collaborator

noelmiller commented Apr 8, 2024

Interesting, still broken in Bazzite. I'm gonna do more debugging and see where it's dropping the file.. https://github.com/ublue-os/bazzite/actions/runs/8605449983/job/23581734802

UPDATE: This is because when I'm building the container, it is not pushing it with the deps tag. It's no big deal, I can test this after it's merged into main.

@noelmiller
Copy link
Collaborator

/run build container

@noelmiller
Copy link
Collaborator

Get Job URL is task if failing inconsistently now. Like, sometimes the jobs are firing off and other times they get held up by that. At any rate, I feel pretty confident we can merge this regarding of some failing tests. I can open a separate issue if you'd like for the failing tests issue.
I've tried 3 times to fire off with my changes I made and it's been getting some of them to go each time: https://github.com/JasonN3/build-container-installer/actions/runs/8605801976/job/23588354201

@JasonN3
Copy link
Owner Author

JasonN3 commented Apr 9, 2024

@noelmiller, you need to fix the Codacy issue

@JasonN3
Copy link
Owner Author

JasonN3 commented Apr 9, 2024

Once that's fixed, I can merge it since the separate run (https://github.com/JasonN3/build-container-installer/actions/runs/8608830718) passed all the tests.

@JasonN3
Copy link
Owner Author

JasonN3 commented Apr 9, 2024

/run tests

@JasonN3 JasonN3 linked an issue Apr 9, 2024 that may be closed by this pull request
@JasonN3
Copy link
Owner Author

JasonN3 commented Apr 9, 2024

Passing tests at https://github.com/JasonN3/build-container-installer/actions/runs/8616695515/job/23615920632
There are currently too many jobs for the bot commands to work. Per-page is increased in this PR to allow future PRs to pass

@JasonN3 JasonN3 merged commit 02c3b10 into main Apr 9, 2024
7 of 12 checks passed
@JasonN3 JasonN3 deleted the deps branch April 9, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] xorriso is not copying over sb_pubkey.der
2 participants