-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jans-cedarling): update Trusted Issuers schema in the policy store #10141
Conversation
Signed-off-by: rmarinn <[email protected]>
- Update the trusted_issuers field in the PolicyStore to reflect the new schema. - Remove the identity_source field has been removed since it has duplicate function with the trusted_issuers field. Signed-off-by: rmarinn <[email protected]>
Signed-off-by: rmarinn <[email protected]>
DryRun Security SummaryThe pull request focuses on enhancing the security and reliability of the Cedarling application, a policy-based access control system, by introducing trusted issuer configurations, improving token validation and claim parsing, updating the policy store schema and definitions, and implementing comprehensive error handling and robustness measures. Expand for full summarySummary: The code changes in this pull request focus on enhancing the security and reliability of the Cedarling application, which is a policy-based access control system. The changes span across multiple files and cover various aspects of the application's security architecture, including:
Overall, the changes in this pull request demonstrate a strong focus on application security, with a particular emphasis on token validation, trusted identity management, and secure policy enforcement. These improvements are crucial for maintaining the integrity and reliability of the Cedarling application, which is likely dealing with sensitive user data and access control mechanisms. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We need to ensure all test cases run with the Trusted Issuers schema changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
My only question is this: will the identity_source
to trusted_issuers
rename prevent the import of a policy file exported by Policy Designer?
If so, will Policy Designer export be updated?
…arling-10038-redo Signed-off-by: Oleh Bohzok <[email protected]>
Update was made to support last structure in the wiki |
Signed-off-by: Oleh Bohzok <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the basis that Policy Designer will now output trusted_issuers
instead of identity_source
Prepare
Description
This PR updates the parser to handle the new Trusted Issuers and Token Entity Metadata schemas.
Target issue
The issue addressed by this PR involves users being unable to directly use policy stores exported from Agama Lab's Policy Designer.
closes #10038
Implementation Details
Updated Trusted Issuers Schema
Updated Token Entity Metadata schema (used for: access_tokens, id_tokens, usrinfo_tokens, and tx_tokens).
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.