Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Visible Link to RSS Feed #407

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Coder206
Copy link
Member

@Coder206 Coder206 commented Dec 14, 2018

Fixes #299
Proudly contributed from Janitor

<section class="blog">{{
<section class="blog">
<a class="btn btn-primary" href="https://discourse.janitor.technology/c/propaganda/blog.rss">RSS Feed</a>
{{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I like moving this to a new line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be this?

    <a class="btn btn-primary" href="https://discourse.janitor.technology/c/propaganda/blog.rss">RSS Feed</a>{{

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that more, thank you @notriddle

Copy link
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the way it looks with the PR. @arshdkhn1 Do you have suggestions on how to do this?

@jankeromnes jankeromnes removed their request for review October 13, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants