Include Grafana Cloud Example; Support passing username/password via URL #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108
Partially addresses docs mentioned in #140
This PR addresses two problems:
https://foo:bar@host
) the request library does not respect this and pass it along. This is causing a lot of people to do work-arounds and get confusedNote that users can now either use
basicAuth
in options, or can specify the username/password in the URL. It is apparent from the issues & forum postings that people are doing both, so it makes sense to support both.The issue this PR fixes is also discussed here and has been viewed over 7,000 times as of this writing.
Thank you for putting together this winston-loki transport! It's really nice and a lot of people are benefitting from it. I hope this helps clear up confusions for some people without touching what people already rely on.