Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added source as a query filter #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Francescu
Copy link

Possible values are search, navigation, apps, websites, unknown

@Francescu Francescu force-pushed the feature/filter_source_type branch from 4d3c79d to 8218ff1 Compare September 13, 2017 13:53
Possible values are search, navigation, apps, websites, unknown
@Francescu Francescu force-pushed the feature/filter_source_type branch from 8218ff1 to 5142129 Compare September 13, 2017 13:55
@JanHalozan
Copy link
Owner

Sorry for getting back to you so late. Did you test this out? I'm assuming that it works.
But I do have a question - is the source applicable in both Metrics and Sources queries?

If not there is one more change to be made - to make sure that when source is removed when switching to sources query.

@Francescu
Copy link
Author

Sorry, I don't remember if it works for Sources queries as well. I think I tested only on Metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants