This repository has been archived by the owner on Jul 1, 2023. It is now read-only.
Look for fatal errors before syntax errors #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakubOnderka
suggested changes
Aug 12, 2018
src/Process/LintProcess.php
Outdated
| @@ -47,8 +47,16 @@ public function hasSyntaxError() | |||
| public function getSyntaxError() | |||
| { | |||
| if ($this->hasSyntaxError()) { | |||
| //Look for fatal errors first | |||
There was a problem hiding this comment.
Just code style: Please add space after // and then I will merge it :)
JakubOnderka
approved these changes
Aug 13, 2018
|
Thanks, merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was banging my head all morning until I finally understood what the problem was in #90
This PR prioritizes fatal errors above parser errors, essentially errors above warnings.
I ran into the exact same problem mentioned by the OP, I had
declare(strict_types=1);at the head of my file which is a warning for older versions of PHP but I also accidentally included a return type on one of my functions which is a fatal error for older versions. The warning can usually be safely ignored so the error should be exposed first.