Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made log tag protected as requested in issue #477 #488

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Made log tag protected as requested in issue #477 #488

wants to merge 1 commit into from

Conversation

CI-Till-Krempel
Copy link

ildar2
ildar2 reviewed Oct 6, 2023
View reviewed changes
timber/src/main/java/timber/log/Timber.kt
@@ -22,7 +22,7 @@ class Timber private constructor() {
internal val explicitTag = ThreadLocal<String>()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There probably should be a change here as well, as you want users to be able to manually set tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildar2 ildar2 ildar2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CI-Till-Krempel @ildar2