Change generic assertFails to assertFailure with specific exception
#614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EpicDima
commented
Jan 3, 2025
| @@ -41,7 +41,8 @@ class OffsetTest { | |||
| TestFiller(modifier = Modifier.size(1)) | |||
| } | |||
| } | |||
| assertFails { | |||
| // check when going beyond the border of the TextSurface#get | |||
There was a problem hiding this comment.
We should probably change the logic inside TextSurface#get, because otherwise using Modifier.offset is dangerous due to crashes, which is not present in the same cases in the Compose UI, for example.
We can do as in #255 or in another way.
|
I will rebase this after my next PR which is a big test migration. |
JakeWharton
force-pushed
the
epicdima/remove_assert_fails
branch
from
1b4c327 to
b0b0218
Compare
JakeWharton
force-pushed
the
epicdima/remove_assert_fails
branch
from
b0b0218 to
bae8753
Compare
JakeWharton
changed the title
assertFails to assertFailsWith with specific exceptionassertFails to assertFailure with specific exception
|
I switched to a custom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #611
CHANGELOG.md's "Unreleased" section has been updated, if applicable.