Fix errors in FGBrushlessDCMotor #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRBLDC_first_release
Co-authored-by: Bertrand Coconnier <[email protected]>
Co-authored-by: Bertrand Coconnier <[email protected]>
Co-authored-by: Bertrand Coconnier <[email protected]>
Co-authored-by: Bertrand Coconnier <[email protected]>
Co-authored-by: Bertrand Coconnier <[email protected]>
Co-authored-by: Bertrand Coconnier <[email protected]>
Co-authored-by: Bertrand Coconnier <[email protected]>
Co-authored-by: Bertrand Coconnier <[email protected]>
|
@pbecchi it looks like you never updated and merged in the previous commit/PR that had been merged into JSBSim:master into your fork? This PR is showing 7 files changed and there are merge conflicts. Good to see the reference to the document on the motor model, this is exactly what I was looking for previously. |
bcoconni
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR correct an substantial error on previous PR #560 , 2 other formal corrections are also included.