Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored function names in R/summarize.R #79

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Refactored function names in R/summarize.R #79

merged 5 commits into from
Oct 8, 2024

Conversation

teddyCodex
Copy link
Collaborator

Description

Refactored specified function names in R/summarize.R based on issue #7

Original Modified User Facing
filter_by_doms filterByDomains  ✅
count_bycol countByColumn  ✅
elements2words elements2Words  
find_paralogs findParalogs  ✅
words2wc words2WordCounts  
filter_freq filterByFrequency  ✅
summarize_bylin summarizeByLineage  ✅
summ.DA.byLin summarizeDomArch_ByLineage  ✅
summ.DA summarizeDomArch  ✅
summ.GC.byDALin summarizeGenContext_ByDomArchLineage  ✅
summ.GC.byLin summarizeGenContext_ByLineage  ✅
summ.GC summarizeGenContext  ✅
total_counts totalGenContextOrDomArchCounts ✅

Fixes issue #53

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
  • Reviewer assignment: Tag a relevant team member to review and approve the changes.

@teddyCodex teddyCodex requested a review from the-mayer October 8, 2024 14:49
@the-mayer the-mayer self-assigned this Oct 8, 2024
@the-mayer the-mayer linked an issue Oct 8, 2024 that may be closed by this pull request
Replace the function names in R/summarize.R #53
Closed
@the-mayer the-mayer added the bug Something isn't working label Oct 8, 2024
the-mayer
the-mayer approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@the-mayer the-mayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a few instances where the prescribed casing was not included -- I have made modifications to match #53 . Additionally, new function names were updated throughout MolEvolvR pkg.

Thanks for the contribution!

@the-mayer the-mayer merged commit a7219d0 into JRaviLab:main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mayer the-mayer the-mayer approved these changes

Assignees

@the-mayer the-mayer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace the function names in R/summarize.R
2 participants
@teddyCodex @the-mayer