Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored function names in R/fa2domain.R #59

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

teddyCodex
Copy link
Collaborator

@teddyCodex teddyCodex commented Oct 6, 2024

Description

Refactored functions in R/fa2domain.R based on #7

Original Modified User Facing
exec_interproscan runIPRScan
get_df_ipr_col_names getIPRScanColNames
get_df_ipr_col_types getIPRScanColTypes
read_iprscan_tsv readIPRScanTSV
make_df_iprscan_domains createIPRScanDomainTable
df_iprscan_domains2fasta convertIPRScanDomainTable2FA
fasta2fasta_domain getDomainsFromFA

Fixes issue #45

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
  • Reviewer assignment: Tag a relevant team member to review and approve the changes.

@teddyCodex
Copy link
Collaborator Author

@jananiravi @the-mayer
File containing other occurrences of the functions. Please let me know if I should commit this file as well.

function_occurrences #45.txt

@jananiravi
Copy link
Member

@teddyCodex, few minor fixes | also indicated in the original issue:
runInterProScan --> runIPRScan
getIPRScanColnames --> getIPRScanColNames
getIPRScanColtypes --> getIPRScanColTypes

Could you double-check against my issue-specific notes + changes in the original issue #7?

@the-mayer the-mayer linked an issue Oct 7, 2024 that may be closed by this pull request
Copy link
Collaborator

@the-mayer the-mayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teddyCodex , updating the docs and merging!

@the-mayer the-mayer merged commit 2c35324 into JRaviLab:main Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the function names in R/fa2domain.R
3 participants