Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor function names in R/CHANGED-pre-msa-tree.R #57

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

teddyCodex
Copy link
Collaborator

@teddyCodex teddyCodex commented Oct 6, 2024

Description

Refactored functions in R/CHANGED-pre-msa-tree.R based on #7

Original Modified User Facing
convert_aln2fa convertAlignment2FA
to_titlecase convert2TitleCase
add_leaves addLeaves2Alignment
generate_all_aln2fa generateAllAlignments2FA
convert_aln2tsv convertAlignment2TSV
convert_accnum2fa convertAccNum2FA
add_name addName
map_acc2name mapAcc2Name
rename_fasta renameFA
acc2fa acc2FA

Fixes issue #37

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
  • Reviewer assignment: Tag a relevant team member to review and approve the changes.

@teddyCodex teddyCodex requested review from the-mayer, jananiravi and Seyi007 and removed request for the-mayer October 6, 2024 16:38
@teddyCodex
Copy link
Collaborator Author

teddyCodex commented Oct 6, 2024

@jananiravi @the-mayer
File containing other occurrences of the functions. Please let me know if I should commit this file as well.

function_occurrences.txt

@teddyCodex teddyCodex requested review from the-mayer and removed request for Seyi007 October 6, 2024 18:04
@jananiravi
Copy link
Member

convertAccNumber2FA --> convertAccNum2FA
mapAccession2Name --> mapAcc2Name

changes made in original issue #7 + this specific issue. could you double-check, @teddyCodex?

@teddyCodex
Copy link
Collaborator Author

@jananiravi changes for this file effected.

Copy link
Collaborator

@the-mayer the-mayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions, merging!

@the-mayer the-mayer merged commit 42c35ff into JRaviLab:main Oct 7, 2024
1 check passed
@the-mayer the-mayer linked an issue Oct 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename functions in R/CHANGED-pre-msa-tree.R file
3 participants