Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for IPv6 agent to request node #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JKRhb
Copy link
Owner

@JKRhb JKRhb commented Feb 20, 2021

This PR is a potential fix for #15, adding an option to the request node for using a globalAgentIPv6 in the underlying node-coap instead of its IPv4 counterpart.

Once it is merged, the PR may fix #15. More testing and investigation is required, however.

@coveralls
Copy link

coveralls commented Feb 20, 2021

Pull Request Test Coverage Report for Build 584592034

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 89.944%

Files with Coverage Reduction New Missed Lines %
coap/coap-request.js 4 91.92%
Totals Coverage Status
Change from base Build 584381314: -0.9%
Covered Lines: 116
Relevant Lines: 126

💛 - Coveralls

@JKRhb JKRhb force-pushed the ipv6-request-option branch 2 times, most recently from ff61e57 to 0cd6a86 Compare November 25, 2021 13:46
@JKRhb JKRhb force-pushed the ipv6-request-option branch from 0cd6a86 to 3781db5 Compare April 3, 2022 16:18
@JKRhb JKRhb force-pushed the ipv6-request-option branch from 3781db5 to 2f23297 Compare August 21, 2022 16:53
@JKRhb JKRhb force-pushed the ipv6-request-option branch from 2f23297 to ca9cf14 Compare July 4, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPv6 AAAA records don't connect, while raw [::] addresses do
2 participants