Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESMF for NRL applications from 8.7.0 to 8.8.0b06, fix py-xarrray dependency in py-xnrl, update PrgEnv on Narwhal #1385

Merged
merged 17 commits into from
Dec 2, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Nov 19, 2024

Summary

  1. Update ESMF for NRL applications from 8.7.0 to 8.8.0b06. I am also making the updates to modules_*.yaml for the upcoming 8.8.0 release (expected January 2025).
  2. Fix py-xarrray dependency in py-xnrl: [email protected] doesn't work with py-xarray@2024:
  3. Update PrgEnv on Narwhal for the remaining compilers from 8.3.3 to 8.4.0.

Testing

  • CI
  • Manual installations of spack-stack with this ESMF on Narwhal, Nautilus, Atlantis

Applications affected

NEPTUNE

Systems affected

Narwhal, Nautilus, Atlantis

Dependencies

Issue(s) addressed

n/a

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji self-assigned this Nov 19, 2024
@climbfuji climbfuji added the NAVY United States Naval Research Lab label Nov 19, 2024
@climbfuji climbfuji requested review from AlexanderRichert-NOAA and theurich and removed request for theurich and AlexanderRichert-NOAA November 19, 2024 03:07
@climbfuji climbfuji changed the title Update ESMF for NRL applications from 8.7.0 to 8.8.0b06 Update ESMF for NRL applications from 8.7.0 to 8.8.0b06, fix py-xarrray dependency in py-xnrl, update PrgEnv on Narwhal Nov 22, 2024
@climbfuji climbfuji marked this pull request as ready for review November 27, 2024 01:11
@climbfuji
Copy link
Collaborator Author

@theurich @areinecke @AlexanderRichert-NOAA This PR is ready for review and merging. Thanks!

Copy link
Collaborator

@theurich theurich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly wondering whether ESMF 8.8.0 should already be in the modules when it is not yet available.

^[email protected]~debug snapshot=none: 'esmf-8.7.0'
^[email protected]+debug snapshot=none: 'esmf-8.7.0-debug'
^[email protected]~debug snapshot=none: 'esmf-8.8.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since beta tags lead up to the final release, it might be better (i.e. less confusing) to have the two 8.8.0 lines after the 8.8.0b06 lines.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I see that other parts in spack-stack will need updating once 8.8.0 is actually available... maybe don't list those lines here yet to prevent confusion about 8.8.0 availability?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order is just a convention we've been using until now, but that's easy to change. I can also take out 8.8.0 until it is available so that we don't have to deal with the ordering for now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes more sense to me to take 8.8.0 out for now, until it is actually available.

^[email protected]~debug snapshot=none: 'esmf-8.7.0'
^[email protected]+debug snapshot=none: 'esmf-8.7.0-debug'
^[email protected]~debug snapshot=none: 'esmf-8.8.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since beta tags lead up to the final release, it might be better (i.e. less confusing) to have the two 8.8.0 lines after the 8.8.0b06 lines.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I see that other parts in spack-stack will need updating once 8.8.0 is actually available... maybe don't list those lines here yet to prevent confusion about 8.8.0 availability?

@climbfuji climbfuji requested a review from theurich December 2, 2024 17:24
Copy link
Collaborator

@theurich theurich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@climbfuji climbfuji enabled auto-merge (squash) December 2, 2024 17:51
@climbfuji climbfuji merged commit 5c40f2e into JCSDA:develop Dec 2, 2024
9 checks passed
@climbfuji climbfuji deleted the feature/esmf880b06 branch December 2, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NAVY United States Naval Research Lab
Projects
Development

Successfully merging this pull request may close these issues.

3 participants