-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ESMF for NRL applications from 8.7.0 to 8.8.0b06, fix py-xarrray dependency in py-xnrl, update PrgEnv on Narwhal #1385
Conversation
…ites/tier1/nautilus/compilers.yaml
…eature/oneapi2025_nautilus_comments
9769781
to
2ff5dd8
Compare
…eature/esmf880b06
…eature/esmf880b06
eebd611
to
ccc2866
Compare
@theurich @areinecke @AlexanderRichert-NOAA This PR is ready for review and merging. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly wondering whether ESMF 8.8.0 should already be in the modules when it is not yet available.
configs/common/modules_lmod.yaml
Outdated
^[email protected]~debug snapshot=none: 'esmf-8.7.0' | ||
^[email protected]+debug snapshot=none: 'esmf-8.7.0-debug' | ||
^[email protected]~debug snapshot=none: 'esmf-8.8.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since beta tags lead up to the final release, it might be better (i.e. less confusing) to have the two 8.8.0
lines after the 8.8.0b06
lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I see that other parts in spack-stack will need updating once 8.8.0
is actually available... maybe don't list those lines here yet to prevent confusion about 8.8.0 availability?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order is just a convention we've been using until now, but that's easy to change. I can also take out 8.8.0 until it is available so that we don't have to deal with the ordering for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, makes more sense to me to take 8.8.0 out for now, until it is actually available.
configs/common/modules_tcl.yaml
Outdated
^[email protected]~debug snapshot=none: 'esmf-8.7.0' | ||
^[email protected]+debug snapshot=none: 'esmf-8.7.0-debug' | ||
^[email protected]~debug snapshot=none: 'esmf-8.8.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since beta tags lead up to the final release, it might be better (i.e. less confusing) to have the two 8.8.0
lines after the 8.8.0b06
lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I see that other parts in spack-stack will need updating once 8.8.0 is actually available... maybe don't list those lines here yet to prevent confusion about 8.8.0 availability?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
Summary
8.7.0
to8.8.0b06
. I am also making the updates tomodules_*.yaml
for the upcoming 8.8.0 release (expected January 2025).py-xarrray
dependency inpy-xnrl
:[email protected]
doesn't work withpy-xarray@2024:
Testing
Applications affected
NEPTUNE
Systems affected
Narwhal, Nautilus, Atlantis
Dependencies
Issue(s) addressed
n/a
Checklist