-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and test Docket image #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blueprint instead of ci-report-converter - Updated Dockerfile to use php:8.3-cli-alpine - Updated Makefile to remove ci-report-converter - Updated GitHub workflows to use csv-blueprint instead of ci-report-converter
1 similar comment
- Add `--ansi` option to the 'docker run' command for the Docker Image - Set execute permission for the 'csv-blueprint' file in the Dockerfile - Change docker build tag in the Makefile to 'csv-blueprint'
Update the versions of Symfony components to 6.4.4 in the composer.lock file. It also updates the PHP requirement to be >=8.1 and updates the conflict versions in the require and require-dev sections accordingly.
- Change the Docker image tag to "jbzoo/csv-blueprint" - Add a new command "demo-invalid-docker" to run demo valid CSV via Docker - Update PHP version to 8.1 in the Dockerfile - Install PHP extensions using "--chmod=0755" in the Dockerfile
Refactored Docker command in main.yml to use make demo-docker with continue-on-error option and updated the Makefile to include demo-docker target for running demos via Docker.
- Add Docker container usage to README - Update PHPUnit test setup for Docker container use
- Add build and test instructions for phar and docker image in the workflow file. - Use a multi-line script to specify commands for each step.
Correct the typo "dcoker" to "Docker" in the name of the Docker image step and add the --ansi flag for better output visibility.
- Renamed "pure-php" job to "reports" and updated the steps to generate different types of reports for CSV validation. Also, added a new job "php" for pure PHP tasks and updated the steps accordingly.
Added validation steps to check for both valid and invalid CSV files. This includes running validations against the demo.csv file using the appropriate schemas to ensure the correctness of the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.