Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaping names passed to Overpass #2074

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Escaping names passed to Overpass #2074

merged 4 commits into from
Nov 13, 2024

Conversation

zstadler
Copy link
Member

Resolves #2073

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.62%. Comparing base (f03ad4d) to head (42696ae).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2074      +/-   ##
==========================================
+ Coverage   90.46%   90.62%   +0.15%     
==========================================
  Files         101      101              
  Lines        8572     8573       +1     
  Branches     1074     1074              
==========================================
+ Hits         7755     7769      +14     
+ Misses        589      576      -13     
  Partials      228      228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zstadler zstadler marked this pull request as draft November 13, 2024 16:43
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ zstadler
❌ HarelM
You have signed the CLA already but the status is still pending? Let us recheck it.

@HarelM HarelM marked this pull request as ready for review November 13, 2024 22:00
@HarelM
Copy link
Member

HarelM commented Nov 13, 2024

After the fix:
image

@HarelM HarelM merged commit 8a41fd0 into main Nov 13, 2024
6 of 7 checks passed
@HarelM HarelM deleted the zstadler-patch-1 branch November 13, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry of searching for נחל מהר"ל is too short
4 participants